Skip to content

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 24, 2025

A few enhancements:

  • Restrict the permissions; we only need read access
  • Run the action from the PR, not from the target, so we can more easily iterate on this logic. As long as it has no write permissions, we are good.
  • Sort keys to match the other actions

Context: I was cleaning up a bit the issue description of mui/mui-public#206, I read this file, and it seemed strange.

@oliviertassinari oliviertassinari added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: support-infra Involves the support-infra product (https://www.notion.so/mui-org/1a4cbfe7b660809c8896d534a9c7d50f). labels Aug 24, 2025
@mui-bot
Copy link

mui-bot commented Aug 24, 2025

Deploy preview: https://deploy-preview-19303--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against a81bb62

@oliviertassinari oliviertassinari added the security Pull requests that address a security vulnerability. label Aug 24, 2025
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to monitor if we maybe need to switch back to target...

The permissions were needed before, when we were still adding a comment. I did forget to clean that up, sry!

@oliviertassinari
Copy link
Member Author

We need to monitor if we maybe need to switch back to target

Agree, I'm merging, I will test it and report back here.

when we were still adding a comment.

Oh, ok, so we can do this too: mui/mui-public#602.

@oliviertassinari oliviertassinari merged commit c0790a4 into mui:master Aug 24, 2025
26 checks passed
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 24, 2025

Agree, I'm merging, I will test it and report back here.

Ok, all good, it still works. Proof:

SCR-20250824-qgfy

#19304

@oliviertassinari oliviertassinari deleted the pr-labels branch August 24, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: support-infra Involves the support-infra product (https://www.notion.so/mui-org/1a4cbfe7b660809c8896d534a9c7d50f). security Pull requests that address a security vulnerability. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants