Skip to content

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 23, 2025

By default, the pull_request type has opened, synchronize, reopened https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target. It seems to be all we need. I was surprised to see this action trigger when a label was applied. It was added in #13952. https://codspeed.io/docs/integrations/ci/github-actions says nothing about it either.

Add comments to clarify why.

@oliviertassinari oliviertassinari added test performance internal Behind-the-scenes enhancement. Formerly called “core”. scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Aug 23, 2025
@mui-bot
Copy link

mui-bot commented Aug 23, 2025

Deploy preview: https://deploy-preview-19302--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against d7383fd

Copy link

codspeed-hq bot commented Aug 23, 2025

CodSpeed Performance Report

Merging #19302 will not alter performance

Comparing oliviertassinari:simpler-codspeed-setup (d7383fd) with master (a937dc5)1

Summary

✅ 10 untouched benchmarks

Footnotes

  1. No successful run was found on master (edd5484) during the generation of this report, so a937dc5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@JCQuintas
Copy link
Member

@oliviertassinari this action checks for scope: charts label. I've left a comment on the file itself explaining the checks, as the conditional is a bit extensive.

Without labeled, L2 wouldn't work.

    # L1: Run the benchmarks for pushes to the master or next branch and if the changes are in the charts package based on on.push.paths
    # L2: Run the benchmarks if we add the label 'scope: charts' to the pull request
    # L3: Run the benchmarks for pull requests with the label 'scope: charts'
    # Yaml syntax looks a little weird, but it is correct.

@oliviertassinari oliviertassinari changed the title [internal] Remove labeled from the Codspeed triggers [internal] Add comment for Codspeed triggers Aug 23, 2025
@JCQuintas JCQuintas enabled auto-merge (squash) August 23, 2025 20:46
@oliviertassinari oliviertassinari added internal Behind-the-scenes enhancement. Formerly called “core”. and removed internal Behind-the-scenes enhancement. Formerly called “core”. labels Aug 24, 2025
@JCQuintas JCQuintas merged commit df308af into mui:master Aug 24, 2025
24 checks passed
@oliviertassinari oliviertassinari deleted the simpler-codspeed-setup branch August 24, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. performance scope: charts Changes related to the charts. test type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants