Skip to content

[charts] Handle item identifier with data #19295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2025
Merged

[charts] Handle item identifier with data #19295

merged 2 commits into from
Aug 22, 2025

Conversation

JCQuintas
Copy link
Member

No description provided.

@JCQuintas JCQuintas self-assigned this Aug 22, 2025
@JCQuintas JCQuintas added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Aug 22, 2025
@JCQuintas JCQuintas mentioned this pull request Aug 22, 2025
Merged
@mui-bot
Copy link

mui-bot commented Aug 22, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19295--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts ▼-248B(-0.08%) ▼-54B(-0.06%)
@mui/x-charts-pro ▼-248B(-0.06%) ▼-37B(-0.03%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against d0aa42b

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19295 will not alter performance

Comparing JCQuintas:with-data (d0aa42b) with master (d557224)

Summary

✅ 10 untouched benchmarks

alexfauquette
alexfauquette approved these changes Aug 22, 2025
View reviewed changes
...charts/src/internals/plugins/featurePlugins/useChartInteraction/useChartInteraction.types.ts
* The item currently interacting.
*/
item: null | ChartItemIdentifier<ChartSeriesType>;
item: null | ChartItemIdentifierWithData<ChartSeriesType>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably be like that when we add control. But for now it's fine as it

Suggested change
item: null | ChartItemIdentifierWithData<ChartSeriesType>;
item: null | ChartItemIdentifier<ChartSeriesType> | ChartItemIdentifierWithData<ChartSeriesType>;

@JCQuintas JCQuintas merged commit a937dc5 into mui:master Aug 22, 2025
25 checks passed
@JCQuintas JCQuintas deleted the with-data branch August 22, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@bernardobelchior bernardobelchior Awaiting requested review from bernardobelchior bernardobelchior is a code owner

Assignees

@JCQuintas JCQuintas

Labels

scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JCQuintas @mui-bot @alexfauquette