Skip to content

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Aug 22, 2025

While working on #19257 i noticed, ?. is used for props where props will always be defined. created PR to remove these instances

@sai6855 sai6855 added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Aug 22, 2025
@mui-bot
Copy link

mui-bot commented Aug 22, 2025

Deploy preview: https://deploy-preview-19292--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) ▼-1B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) ▼-1B(0.00%)
@mui/x-charts ▼-4B(0.00%) ▼-5B(-0.01%)
@mui/x-charts-pro ▼-7B(0.00%) ▼-13B(-0.01%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) ▼-1B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) ▼-1B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 26c9279

@sai6855 sai6855 enabled auto-merge (squash) August 22, 2025 12:31
Copy link

codspeed-hq bot commented Aug 22, 2025

CodSpeed Performance Report

Merging #19292 will not alter performance

Comparing sai6855:code-clean-charts (26c9279) with master (dbd436e)1

Summary

✅ 10 untouched benchmarks

Footnotes

  1. No successful run was found on master (d4a395e) during the generation of this report, so dbd436e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@sai6855 sai6855 merged commit d557224 into mui:master Aug 22, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants