[infra] Migrate to use eslint without airbnb config #19269

brijeshb42 · 2025-08-21T07:24:30Z

Major changes -

@typescript-eslint/no-non-null-asserted-optional-chain has been turned on and will report error. So no more of doing object?.property! this. I have disabled the current issues and fixed in places where I could.
No V extends any since it doesn't actually do anything.
class-methods-use-this has been turned off since we endup always disabling it anyway.

📈 BENCHMARK RESULTS

Command: pnpm eslint:ci

	This PR	master
⏱️ Average	1:07.68	1:13.31
🚀 Fastest	1:04.33	1:07.25
🐌 Slowest	1:09.33	1:21.43
📊 Std Dev	1.32s	4.04s

I have followed (at least) the PR section of the contributing guide.

mui-bot · 2025-08-21T07:26:15Z

Deploy preview: https://deploy-preview-19269--material-ui-x.netlify.app/

Bundle size report

Bundle	Parsed size	Gzip size
@mui/x-data-grid	▼-78B^(-0.02%)	▼-18B^(-0.02%)
@mui/x-data-grid-pro	▼-78B^(-0.02%)	▼-12B^(-0.01%)
@mui/x-data-grid-premium	▼-67B^(-0.01%)	▼-11B^(-0.01%)
@mui/x-charts	▼-2B^(0.00%)	▼-1B^(0.00%)
@mui/x-charts-pro	▼-2B^(0.00%)	🔺+1B^(0.00%)
@mui/x-date-pickers	0B^(0.00%)	0B^(0.00%)
@mui/x-date-pickers-pro	0B^(0.00%)	🔺+7B^(+0.01%)
@mui/x-tree-view	0B^(0.00%)	0B^(0.00%)
@mui/x-tree-view-pro	0B^(0.00%)	🔺+3B^(+0.01%)

Details of bundle changes

Generated by 🚫 dangerJS against edaa791

Janpot · 2025-08-21T11:56:47Z

docs/src/modules/utils/useCustomizationPlayground.tsx

 /* I use this method to parse whatever component props are passed in and format them for the code example, 
 so the code example includes the same props as the rendered component. e.g. the views={['month']} */
+// eslint-disable-next-line @typescript-eslint/no-wrapper-object-types
 function formatComponentProps(componentProps?: Object, spacing: number = 1) {


We can't just update the type here?

Janpot · 2025-08-21T11:59:10Z

eslint.config.mjs

      // TODO move to @mui/internal-code-infra/eslint, these are false positive
      'react/no-unstable-nested-components': ['error', { allowAsProps: true }],
+      // migration rules
+      '@typescript-eslint/no-namespace': 'off',


We already have

mui-x/eslint.config.mjs

Lines 417 to 423 in c478774

{

// TODO: typescript namespaces found to be harmful. Refactor to different patterns. More info: https://github.com/mui/mui-x/pull/19071

ignores: ['packages/x-scheduler/**/*', 'packages/x-virtualizer/**/*'],

rules: {

'@typescript-eslint/no-namespace': 'error',

},

},

Both are different. By default, the rule is turned off and only enabled for x-scheduler and x-virtualizer packages.

My mistake. Its ignores and not files.

Janpot · 2025-08-21T12:05:19Z

packages/x-data-grid-generator/src/hooks/serverUtils.ts

 ): GridValidRowModel[] => {
  let filteredRows = [...rows];
-  if (filterModel && filterModel.quickFilterValues?.length! > 0) {
+  if (filterModel && (filterModel.quickFilterValues?.length as number) > 0) {


If quickFilterValues can be nullable, then why not just handle it like

Suggested change

if (filterModel && (filterModel.quickFilterValues?.length as number) > 0) {

if (filterModel?.quickFilterValues && filterModel.quickFilterValues.length > 0) {

Janpot · 2025-08-21T12:06:45Z

packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputMultipleSingleSelect.tsx

  }

+  // eslint-disable-next-line @typescript-eslint/no-non-null-asserted-optional-chain
  const getOptionValue = resolvedColumn?.getOptionValue!;


Thanks, Can't unsee now how ridiculous this pattern actually is 😄

Janpot

Ok for me.

Would prefer to fix
https://github.com/mui/mui-x/pull/19269/files#diff-136cfbf653bed6242fa84d92939470db5864af54d7ba79551edfbdbbcfd11c4cR28
and
https://github.com/mui/mui-x/pull/19269/files#diff-b0ed7ac72c2450e42859b95ec4e83bb79c3dbfdd7b8bae6d7af5b379b0547704R30
if we safely can.

Otherwise, to the X team for a final approval

JCQuintas · 2025-08-22T12:37:37Z

packages/x-charts/src/RadarChart/RadarSeriesPlot/useRadarSeriesData.ts


  const metrics = (rotationScale?.domain() as (string | number)[]) ?? [];
+  // eslint-disable-next-line @typescript-eslint/no-non-null-asserted-optional-chain
  const angles = metrics.map((key) => rotationScale?.(key)!);


@alexfauquette should do something if rotationScale is not present instead? 🤔

is not if rotationScale is not present. It's if key is not part of rotationScale domain. Which is not possible

if (rotationScale === undefined) { return []; } const metrics = rotationScale.domain() as (string | number)[]; const angles = metrics.map((key) => rotationScale(key)!);

To remove the ! we should support the case where scale return undefined but it feels weirds to handle a case that should not exist just to please TS

The eslint rule issue is with forcing an optional rotationScale(key)! would be acceptable.

And if you're certain that rotationScale can't have nullish values, you should express that as rotationScale!(key)!, not rotationScale?.(key)!.

For now, I have changed it to rotationScale!.(key)! to satisfy TS without any runtime changes.

Janpot · 2025-08-22T12:47:44Z

packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputMultipleSingleSelect.tsx

  const isOptionEqualToValue = React.useCallback(
-    (option: ValueOptions, value: ValueOptions) => getOptionValue(option) === getOptionValue(value),
+    (option: ValueOptions, value: ValueOptions) =>
+      getOptionValue?.(option) === getOptionValue?.(value),


tbh, this still feels wrong, this would always return true if getOptionValue is undefined, even if value and option are not equivalent. If there's a valid reason where resolvedColumn?.getOptionLabel can be undefined, shouldn't it be more like:

const getOptionValue = resolvedColumn?.getOptionValue ?? (value) => value; const getOptionLabel = resolvedColumn?.getOptionLabel ?? (label) => label;

?

Otherwise can we express it correctly in the types? I don't have enough context to fully judge this though.

I didn't want to meddle too much with the runtime because of the same reason. @cherniavskii Could you get this resolved ?

OK, should be done.
Basically, if resolvedColumn is not a single select column, we should just return null.
I've made getOptionLabel and getOptionValue non-nullable, because we assign default ones anyway.

eslint.config.mjs

cherniavskii · 2025-08-22T12:46:59Z

packages/x-data-grid/src/hooks/features/scroll/useGridScroll.ts

-        typeof scrollCoordinates.left !== undefined ||
-        typeof scrollCoordinates.top !== undefined
+        typeof scrollCoordinates.left !== 'undefined' ||
+        typeof scrollCoordinates.top !== 'undefined'


Good catch!

brijeshb42 added scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Aug 21, 2025

brijeshb42 mentioned this pull request Aug 21, 2025

[code-infra] Migrate away from using airbnb config mui/mui-public#556

Merged

brijeshb42 force-pushed the migrate-eslint branch 2 times, most recently from 7dc84b1 to c478774 Compare August 21, 2025 11:04

Janpot reviewed Aug 21, 2025

View reviewed changes

brijeshb42 force-pushed the migrate-eslint branch 3 times, most recently from 685dbad to 507e709 Compare August 21, 2025 14:47

brijeshb42 added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. and removed type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Aug 21, 2025

brijeshb42 force-pushed the migrate-eslint branch from 507e709 to a42d48b Compare August 21, 2025 16:26

brijeshb42 added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. and removed type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Aug 21, 2025

brijeshb42 requested a review from Janpot August 21, 2025 16:45

brijeshb42 marked this pull request as ready for review August 22, 2025 04:58

brijeshb42 requested review from JCQuintas, alexfauquette and bernardobelchior as code owners August 22, 2025 04:58

brijeshb42 requested a review from a team August 22, 2025 04:58

Janpot reviewed Aug 22, 2025

View reviewed changes

brijeshb42 force-pushed the migrate-eslint branch from 07394f9 to 0cc7ec2 Compare August 22, 2025 06:25

brijeshb42 added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. and removed type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Aug 22, 2025

JCQuintas reviewed Aug 22, 2025

View reviewed changes

Janpot reviewed Aug 22, 2025

View reviewed changes

cherniavskii approved these changes Aug 22, 2025

View reviewed changes

brijeshb42 force-pushed the migrate-eslint branch from 0cc7ec2 to 6c70c24 Compare August 25, 2025 13:09

brijeshb42 added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. and removed type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Aug 25, 2025

JCQuintas approved these changes Aug 25, 2025

View reviewed changes

brijeshb42 added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. and removed type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Aug 26, 2025

brijeshb42 requested a review from Janpot August 26, 2025 04:33

brijeshb42 and others added 5 commits August 26, 2025 10:05

[infra] Migrate to use eslint without airbnb config

56a51a1

review fixes

a74e970

make getOptionValue and getOptionLabel non-nullable

f9a198b

docs:api

6223b4e

return if column is not singleSelect

3624316

brijeshb42 force-pushed the migrate-eslint branch 2 times, most recently from ec9a539 to 53482d3 Compare August 26, 2025 04:39

Fix TS

edaa791

brijeshb42 force-pushed the migrate-eslint branch from 53482d3 to edaa791 Compare August 26, 2025 04:42

Janpot approved these changes Aug 26, 2025

View reviewed changes

brijeshb42 added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. and removed type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Aug 26, 2025

brijeshb42 merged commit 90d94c7 into mui:master Aug 26, 2025
22 of 23 checks passed

brijeshb42 deleted the migrate-eslint branch August 26, 2025 06:56

	{
	// TODO: typescript namespaces found to be harmful. Refactor to different patterns. More info: https://github.com/mui/mui-x/pull/19071
	ignores: ['packages/x-scheduler/*/', 'packages/x-virtualizer/*/'],
	rules: {
	'@typescript-eslint/no-namespace': 'error',
	},
	},

	if (filterModel && (filterModel.quickFilterValues?.length as number) > 0) {
	if (filterModel?.quickFilterValues && filterModel.quickFilterValues.length > 0) {

Uh oh!

[infra] Migrate to use eslint without airbnb config #19269

[infra] Migrate to use eslint without airbnb config #19269

Uh oh!

Conversation

brijeshb42 commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📈 BENCHMARK RESULTS

Uh oh!

mui-bot commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle size report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Janpot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Janpot Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Janpot Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

brijeshb42 commented Aug 21, 2025 •

edited

Loading

mui-bot commented Aug 21, 2025 •

edited

Loading

Janpot Aug 25, 2025 •

edited

Loading

Janpot Aug 22, 2025 •

edited

Loading