[tree view] Expose the methods to manually refetch the children of an item #19248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-19248--material-ui-x.netlify.app/ Updated pages:
Bundle size report
|
flaviendelangle
added
type: new feature
flaviendelangle
force-pushed
the
refetch-children
branch
from
c1d517c to
4a2aa73
Compare
flaviendelangle
force-pushed
the
refetch-children
branch
from
4a2aa73 to
42a17f0
Compare
flaviendelangle
added
type: bug
noraleonte
approved these changes
Aug 29, 2025
| <Button onClick={checkExpansion}> | ||
| Check if the the Data Grid is expanded | ||
| </Button> | ||
| <Snackbar |
There was a problem hiding this comment.
I like the idea of this demo, but maybe we could try containing the snackbar inside the demo container 🤔
Also, if the snackbar is open and we click the button again, the snackbar closes. To me the toggle behavior is weird, so maybe we could disable the button while the snackbar is open, WDYT? 🎉
There was a problem hiding this comment.
Clicking anywhere closes the snackbar, it's not specific to the button 👍
flaviendelangle
force-pushed
the
refetch-children
branch
2 times, most recently
from
22a3fd5 to
fd5683f
Compare
flaviendelangle
force-pushed
the
refetch-children
branch
from
fd5683f to
1e31e5d
Compare
Bundle size report
|
JCQuintas
pushed a commit
to JCQuintas/mui-x
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18200
If we expose
publicAPI.fetchItems, then we need to add a param to it to allow to skip the cache (otherwise the data is just read from the cache). The DX would not be great because people would always use this param.We could expose a
publicAPI.updateItemsthen we have a good DX, but we need to update the behavior of the queue and I'm afraid to run into edge cases (if we have some requests in the queue that want to ignore the cache but not others). I'm not sure it's worth the complexity and potential bugs, which is why I sticked by the simplerpublicAPI.updateItemwhich seems like a good starting point.