Skip to content

Conversation

Methuselah96
Copy link
Contributor

Fixes #19050

This will cause the type definitions to use import("@mui/x-internals/throttle").Cancelable instead of import("@mui/x-internals/throttle/throttle").Cancelable which fixes the type error

Copy link
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! We should probably always use export *.

@romgrk romgrk added scope: data grid Changes related to the data grid. type: regression A bug, but worse, it used to behave as expected. labels Aug 14, 2025
@romgrk romgrk enabled auto-merge (squash) August 14, 2025 21:10
@Methuselah96
Copy link
Contributor Author

@romgrk I'm not sure why CI isn't running, let me know if there's anything else I can do

@mui-bot
Copy link

mui-bot commented Aug 15, 2025

Deploy preview: https://deploy-preview-19192--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against d217eab

@romgrk
Copy link
Contributor

romgrk commented Aug 15, 2025

I've triggered the CI. I missed that it hadn't run, this fix won't be in this week's release, it will be available next week.

@romgrk romgrk merged commit 6c2b759 into mui:master Aug 15, 2025
20 checks passed
@Methuselah96 Methuselah96 deleted the fix-ts-issues branch August 15, 2025 18:50
@oliviertassinari oliviertassinari changed the title [virtualizer] fix: type import [virtualizer] Fix type import Aug 15, 2025
@oliviertassinari oliviertassinari changed the title [virtualizer] Fix type import [data grid] Fix virtualizer type import Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: data grid Changes related to the data grid. type: regression A bug, but worse, it used to behave as expected. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[data grid] @mui/x-virtualizer TypeScript error

4 participants