[scheduler]Add an option to show/hide the weekends #19053

rita-codes · 2025-08-04T16:59:39Z

In this PR:

Add a toggle in the setting menu that allow to show / hide the weekends
Apply this setting to the week, month and agenda view (should not impact the day view)
The new component will be placed inside the HeaderToolbar. Adjust the styles to account for cases where the middle buttons are centered, and when they are aligned to the end (when the ViewSwitcher is not present).
Add tests for all the views
Add styles following the current ViewSwitcher styles, but this can be adjusted based on @noraleonte 's input

Bonus: 🧹

Fixed typo in the demo data
Improve AgendaView accessibility

Not in this PR:

Allow people to control / initialize this setting
Allow people to hide this setting
State persistence

Demo with middle buttons centered
https://github.com/user-attachments/assets/98517ffd-6c7c-4a93-a588-809a64de0f54

Demo with the buttons aligned to the end
https://github.com/user-attachments/assets/2a0b98ef-c0de-4a2b-b68c-e39dfc0d592f

I have followed (at least) the PR section of the contributing guide.

…whide-the-week-end

mui-bot · 2025-08-04T17:01:40Z

Deploy preview: https://deploy-preview-19053--material-ui-x.netlify.app/

Bundle size report

Bundle	Parsed Size	Gzip Size
@mui/x-data-grid	0B^(0.00%)	0B^(0.00%)
@mui/x-data-grid-pro	0B^(0.00%)	0B^(0.00%)
@mui/x-data-grid-premium	0B^(0.00%)	0B^(0.00%)
@mui/x-charts	0B^(0.00%)	0B^(0.00%)
@mui/x-charts-pro	0B^(0.00%)	0B^(0.00%)
@mui/x-date-pickers	0B^(0.00%)	0B^(0.00%)
@mui/x-date-pickers-pro	0B^(0.00%)	0B^(0.00%)
@mui/x-tree-view	0B^(0.00%)	0B^(0.00%)
@mui/x-tree-view-pro	0B^(0.00%)	0B^(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 7138606

packages/x-scheduler/src/material/internals/utils/test-utils.ts

packages/x-scheduler/src/primitives/utils/date-utils.ts

noraleonte

Looking good 🎉 Left a small styling suggestion and raised a point that we could discuss 👌

.../x-scheduler/src/material/internals/components/header-toolbar/settings-menu/SettingsMenu.tsx

packages/x-scheduler/src/material/internals/utils/test-utils.ts

packages/x-scheduler/src/material/week-view/WeekView.tsx

…whide-the-week-end

noraleonte

Sorry, I meant to update this icon as well, but I forgot 🙈

.../x-scheduler/src/material/internals/components/header-toolbar/settings-menu/SettingsMenu.tsx

…toolbar/settings-menu/SettingsMenu.tsx Co-authored-by: Nora <[email protected]> Signed-off-by: Rita <[email protected]>

…whide-the-week-end

github-actions · 2025-08-06T15:59:57Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…yled-add-an-option-to-showhide-the-week-end

…whide-the-week-end

noraleonte

Looking good to me 💙 Thanks for your great work on this!

packages/x-scheduler/src/primitives/use-day-list/useDayList.ts

…whide-the-week-end

rita-codes and others added 7 commits August 4, 2025 12:12

fix typo

79a92f2

create button and add selector

cf84809

apply settings to the month, week and agenda view

28d4ff8

add test on the event calendar

3df0634

add tests for all the views and improve agenda view accessibility

d0903fb

add tests for the settings menu component

8e05b94

Merge branch 'master' into 18367-schedulerstyled-add-an-option-to-sho…

072bd96

…whide-the-week-end

rita-codes commented Aug 4, 2025

View reviewed changes

packages/x-scheduler/src/material/internals/utils/test-utils.ts Show resolved Hide resolved

rita-codes commented Aug 4, 2025

View reviewed changes

packages/x-scheduler/src/primitives/utils/date-utils.ts Show resolved Hide resolved

rita-codes self-assigned this Aug 4, 2025

rita-codes added type: new feature Introduces a new piece of functionality or capability. scope: scheduler Changes or issues related to the scheduler product labels Aug 4, 2025

rita-codes added 3 commits August 4, 2025 19:18

fix testS

627a75d

remove

fe994fc

fix utils tests

dec3156

rita-codes requested review from noraleonte and flaviendelangle August 4, 2025 17:41

rita-codes linked an issue Aug 4, 2025 that may be closed by this pull request

[scheduler][styled] Add an option to show/hide the week end #18367

Closed

noraleonte approved these changes Aug 5, 2025

View reviewed changes

rita-codes and others added 2 commits August 5, 2025 19:39

fix icon

0151eba

Merge branch 'master' into 18367-schedulerstyled-add-an-option-to-sho…

7f9870c

…whide-the-week-end

noraleonte approved these changes Aug 6, 2025

View reviewed changes

.../x-scheduler/src/material/internals/components/header-toolbar/settings-menu/SettingsMenu.tsx Outdated Show resolved Hide resolved

rita-codes and others added 2 commits August 6, 2025 14:06

Update packages/x-scheduler/src/material/internals/components/header-…

b002e42

…toolbar/settings-menu/SettingsMenu.tsx Co-authored-by: Nora <[email protected]> Signed-off-by: Rita <[email protected]>

Merge branch 'master' into 18367-schedulerstyled-add-an-option-to-sho…

500c765

…whide-the-week-end

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 6, 2025

rita-codes added 2 commits August 6, 2025 18:40

refactor hook logic to handle also week

648b921

Merge remote-tracking branch 'upstream/master' into 18367-schedulerst…

9170275

…yled-add-an-option-to-showhide-the-week-end

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 6, 2025

Merge branch 'master' into 18367-schedulerstyled-add-an-option-to-sho…

7623fd3

…whide-the-week-end

noraleonte approved these changes Aug 7, 2025

View reviewed changes

packages/x-scheduler/src/primitives/use-day-list/useDayList.ts Outdated Show resolved Hide resolved

rita-codes and others added 2 commits August 7, 2025 10:26

rename var

9078175

Merge branch 'master' into 18367-schedulerstyled-add-an-option-to-sho…

7138606

…whide-the-week-end

rita-codes merged commit d726c55 into mui:master Aug 7, 2025
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[scheduler]Add an option to show/hide the weekends #19053

[scheduler]Add an option to show/hide the weekends #19053

Uh oh!

rita-codes commented Aug 4, 2025 •

edited

Loading

Uh oh!

mui-bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

noraleonte left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noraleonte left a comment

Uh oh!

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

noraleonte left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[scheduler]Add an option to show/hide the weekends #19053

[scheduler]Add an option to show/hide the weekends #19053

Uh oh!

Conversation

rita-codes commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle size report

Uh oh!

Uh oh!

Uh oh!

noraleonte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noraleonte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

noraleonte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rita-codes commented Aug 4, 2025 •

edited

Loading

mui-bot commented Aug 4, 2025 •

edited

Loading