-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[charts-pro] Mark FunnelChart
as stable
#19048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alexfauquette do we need to keep exporting |
Deploy preview: https://deploy-preview-19048--material-ui-x.netlify.app/ Updated pages: Bundle size report
|
CodSpeed Performance ReportMerging #19048 will not alter performanceComparing Summary
Footnotes |
@@ -1,4 +1,5 @@ | |||
export { FunnelChart as Unstable_FunnelChart } from './FunnelChart'; | |||
export { FunnelChart } from './FunnelChart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do something like this so people are inclined to migrate?
export { FunnelChart } from './FunnelChart'; | |
/** | |
* @deprecated funnel chart is now stable, import `FunnelChart` instead | |
*/ | |
export const Unstable_FunnelChart = FunnelChart; |
FunnelChart
Unstable_FunnelChart
to prevent breaking changes