Skip to content

[charts-pro] Mark FunnelChart as stable #19048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 6, 2025
Merged

Conversation

JCQuintas
Copy link
Member

  • export FunnelChart
  • keep exporting Unstable_FunnelChart to prevent breaking changes

@JCQuintas JCQuintas self-assigned this Aug 4, 2025
@JCQuintas JCQuintas added the plan: Pro Impact at least one Pro user label Aug 4, 2025
@JCQuintas JCQuintas added type: enhancement This is not a bug, nor a new feature scope: charts Changes or issues related to the charts product labels Aug 4, 2025
@JCQuintas
Copy link
Member Author

@alexfauquette do we need to keep exporting Unstable_FunnelChart? I saw we did that in the Radar chart so I kept it, but it feels a bit weird. 😄

@mui-bot
Copy link

mui-bot commented Aug 4, 2025

Deploy preview: https://deploy-preview-19048--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed Size Gzip Size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 🔺+25B(+0.01%) 🔺+10B(+0.01%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 34fdf66

Copy link

codspeed-hq bot commented Aug 4, 2025

CodSpeed Performance Report

Merging #19048 will not alter performance

Comparing JCQuintas:funnel-stable (add0e70) with master (9ce51f6)1

Summary

✅ 10 untouched benchmarks

Footnotes

  1. No successful run was found on master (55680dc) during the generation of this report, so 9ce51f6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@@ -1,4 +1,5 @@
export { FunnelChart as Unstable_FunnelChart } from './FunnelChart';
export { FunnelChart } from './FunnelChart';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do something like this so people are inclined to migrate?

Suggested change
export { FunnelChart } from './FunnelChart';
/**
* @deprecated funnel chart is now stable, import `FunnelChart` instead
*/
export const Unstable_FunnelChart = FunnelChart;

@JCQuintas JCQuintas enabled auto-merge (squash) August 6, 2025 15:57
@JCQuintas JCQuintas merged commit 2a7b980 into mui:master Aug 6, 2025
23 checks passed
@JCQuintas JCQuintas deleted the funnel-stable branch August 6, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan: Pro Impact at least one Pro user scope: charts Changes or issues related to the charts product type: enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants