[pickers] Gracefully handle textField.slotProps
#18980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
scope: pickers
|
Deploy preview: https://deploy-preview-18980--material-ui-x.netlify.app/ Bundle size report
|
LukasTy
changed the title
textField.slotProps gracefullytextField.slotProps
packages/x-date-pickers/src/internals/components/PickerFieldUI.tsx
Outdated
Show resolved
Hide resolved
| ? { | ||
| slotProps: { | ||
| ...other?.slotProps, | ||
| input: (ownerState: FieldOwnerState) => ({ |
There was a problem hiding this comment.
Would it work with the resolveComponentProps utility function instead?
There was a problem hiding this comment.
I've updated the solution to use resolveComponentProps .
Also made some other fixes testing various cases and added some tests to ensure at least a semi-stability of this tricky and fragile behavior (until we drop support for Material v5).
Besides, it looks like this now solves #14284 as well. 🎉
JCQuintas
pushed a commit
to JCQuintas/mui-x
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14684.
Fix #14284.
Apply this proposal: #14684 (comment)