Skip to content

[WIP] Scatter fast path #18941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 46 commits into from
Closed

[WIP] Scatter fast path #18941

wants to merge 46 commits into from

Conversation

bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented Jul 28, 2025 •
edited
Loading

Bugs:

  • When the x-axis is reversed it, the closest point is wrong
Screen.Recording.2025-10-01.at.14.50.02.mov

@bernardobelchior bernardobelchior added performance scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Jul 28, 2025
@mui-bot
Copy link

mui-bot commented Jul 28, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-18941--material-ui-x.netlify.app/

Bundle size report

Bundle size will be reported once CircleCI build #638423 finishes.

Generated by 🚫 dangerJS against 22119b2

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #18941 will degrade performances by 23.03%

Comparing bernardobelchior:scatter-fast-path (7025440) with master (9ce51f6)1

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 7 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ ScatterChart with big data amount 797.1 ms 65 ms ×12
⚡ ScatterChartPro with big data amount 437.6 ms 65.2 ms ×6.7
❌ ScatterChartPro with big data amount and zoomed in 54.8 ms 71.2 ms -23.03%

Footnotes

  1. No successful run was found on master (70359f3) during the generation of this report, so 9ce51f6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 28, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Jul 29, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 1, 2025
@bernardobelchior bernardobelchior force-pushed the scatter-fast-path branch 2 times, most recently from ab01726 to c4d7f56 Compare August 4, 2025 08:32
@bernardobelchior bernardobelchior mentioned this pull request Aug 6, 2025
Merged
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 17, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@bernardobelchior bernardobelchior mentioned this pull request Sep 18, 2025
Closed
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 1, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 2, 2025
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@bernardobelchior
Copy link
Member Author

All improvements from this PR have been merged or are available in another PR. Closing.

@bernardobelchior bernardobelchior deleted the scatter-fast-path branch October 13, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexfauquette alexfauquette Awaiting requested review from alexfauquette alexfauquette will be requested when the pull request is marked ready for review alexfauquette is a code owner

@JCQuintas JCQuintas Awaiting requested review from JCQuintas JCQuintas will be requested when the pull request is marked ready for review JCQuintas is a code owner

Assignees

No one assigned

Labels

performance PR: out-of-date The pull request has merge conflicts and can't be merged. scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bernardobelchior @mui-bot