[DataGrid] Filter dropdown label for Columns changed from Columns to Column #18776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Column Since it can only select one column, it should be named Column instead of Columns
|
Deploy preview: https://deploy-preview-18776--material-ui-x.netlify.app/ Bundle size reportBundle size will be reported once CircleCI build #580904 finishes. |
|
Awaiting update here folks. TIA! |
|
@GeneratorX16 @viral-pasad If you need it in your project meanwhile, you could override the locale constant ( |
|
Will open a separate PR during v9 alpha phase, to avoid diff getting bigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since column dropdown in filter can only select one column, it should be named "Column" instead of "Columns".
Closes #18737
Thanks to @MBilalShafi for helping with the fix