[DatePicker]fix firefox bug causing crash when startContainer is Restricted object #18772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webini
changed the title
Webini
changed the title
Webini
changed the title
|
Deploy preview: https://deploy-preview-18772--material-ui-x.netlify.app/ Bundle size report
|
rita-codes
reviewed
Jul 28, 2025
There was a problem hiding this comment.
This fix makes a lot of sense, thanks for catching and addressing it! 🥇
Would you mind adding a small inline comment above the check to explain why it's needed? Something like: "Firefox can return a Restricted object here"
That would help future readers understand why this check is necessary.
Appreciate your work on this! ✨
Webini
force-pushed
the
firefox-restricted-object-bug
branch
from
2246022 to
6629f94
Compare
|
✔️ |
rita-codes
approved these changes
Jul 28, 2025
|
This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days. |
github-actions
bot
added
the
stale
flaviendelangle
added
type: bug
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes, Firefox returns a
Restricted { }object instead of a DOM element fromdocument.getSelection().getRangeAt(0).startContainer.I don't know why or when Firefox does this, but I’ve created a CodeSandbox example where the issue can be reproduced by repeatedly clicking the next/previous month buttons, then clicking outside the date picker popper.
It seems that having the input element present in the DOM is required to reproduce this issue.
Tested on Firefox: 128.12.0esr (64-bit)
demo.mp4