-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[docs] Add Charts example collection page (DX-10) #18353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview: https://deploy-preview-18353--material-ui-x.netlify.app/ Updated pages: Bundle size report
|
CodSpeed Performance ReportMerging #18353 will not alter performanceComparing Summary
|
@alelthomas For #16587 I started exploring charts demos in this PR. The idea was to have a page similar to Data Grid's Features page. So basically list all demos from the docs into a single page. Would you like to continue it from here? Today we discussed that we should replace current data with some real data. |
|
Signed-off-by: Jose C Quintas Jr <[email protected]>
Signed-off-by: Jose C Quintas Jr <[email protected]>
Bundle size report
|
Ugh I'm not so sure I like that look though. I've been discussing this with Nora, and she agrees that removing the whitespace just makes them look more cluttered... I feel like giving them a little bit of space helps. Similar to https://tremor.so/charts |
@alexfauquette Overall it looks good to me now. Do you mind taking a look? |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Prakhar Gupta <[email protected]>
Closes: #16587
Closes #DX-10
Preview: https://deploy-preview-18353--material-ui-x.netlify.app/x/react-charts/examples/