Skip to content

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Jun 12, 2025

@prakhargupta1 prakhargupta1 added docs Improvements or additions to the documentation. scope: charts Changes related to the charts. labels Jun 12, 2025
@mui-bot
Copy link

mui-bot commented Jun 12, 2025

Deploy preview: https://deploy-preview-18353--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 2f9a34f

Copy link

codspeed-hq bot commented Jun 12, 2025

CodSpeed Performance Report

Merging #18353 will not alter performance

Comparing prakhargupta1:charts-demo (2f9a34f) with master (93406bb)

Summary

✅ 10 untouched

@prakhargupta1
Copy link
Member Author

@alelthomas For #16587 I started exploring charts demos in this PR. The idea was to have a page similar to Data Grid's Features page. So basically list all demos from the docs into a single page. Would you like to continue it from here? Today we discussed that we should replace current data with some real data.

@alelthomas alelthomas self-assigned this Jun 17, 2025
@alelthomas alelthomas changed the title [draft] Add Charts example collection page [draft] Add Charts example collection page (DX-10) Jul 17, 2025
@alelthomas alelthomas changed the title [draft] Add Charts example collection page (DX-10) [draft] Add Charts example collection page DX-10 Jul 17, 2025
@alelthomas alelthomas changed the title [draft] Add Charts example collection page DX-10 [draft] Add Charts example collection page Jul 17, 2025
@alelthomas alelthomas changed the title [draft] Add Charts example collection page [draft] DX-10 Add Charts example collection page Jul 17, 2025
@alelthomas alelthomas changed the title [draft] DX-10 Add Charts example collection page [draft] Add Charts example collection page (DX-10) Jul 29, 2025
@alelthomas alelthomas marked this pull request as ready for review August 5, 2025 03:41
@prakhargupta1
Copy link
Member Author

Signed-off-by: Jose C Quintas Jr <[email protected]>
Signed-off-by: Jose C Quintas Jr <[email protected]>
@JCQuintas JCQuintas added the type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. label Sep 2, 2025
@mui-bot
Copy link

mui-bot commented Sep 2, 2025

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) ▼-1B(0.00%)
@mui/x-charts 🔺+12B(0.00%) 🔺+8B(+0.01%)
@mui/x-charts-pro 🔺+12B(0.00%) 🔺+9B(+0.01%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 🔺+1B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

@alelthomas
Copy link
Contributor

  • I see that adding a box to the original demos fixed the layouts. Should we not follow the same for other charts? For instance, area chart demos are still not using the full width.

Ugh I'm not so sure I like that look though. I've been discussing this with Nora, and she agrees that removing the whitespace just makes them look more cluttered... I feel like giving them a little bit of space helps. Similar to https://tremor.so/charts

@prakhargupta1
Copy link
Member Author

On my Macbook, the area chart looks like below, but on a larger screen it looks fine.
Screenshot 2025-09-04 at 1 07 49 AM

Similarly, the pie chart goes out of the box:
Screenshot 2025-09-04 at 1 13 41 AM

@prakhargupta1
Copy link
Member Author

@alexfauquette Overall it looks good to me now. Do you mind taking a look?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 16, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 17, 2025
@alexfauquette alexfauquette merged commit e7b5051 into mui:master Sep 17, 2025
22 of 23 checks passed
@prakhargupta1 prakhargupta1 deleted the charts-demo branch September 17, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation. scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts] Create Demo page
8 participants