[data grid] Improve types in GridEditSingleSelect #18184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding a type label to the PR! 👍 |
sai6855
added
scope: data grid
|
Deploy preview: https://deploy-preview-18184--material-ui-x.netlify.app/ Bundle size report
|
sai6855
commented
Jun 2, 2025
| function isKeyboardEvent(event: any): event is React.KeyboardEvent { | ||
| return !!event.key; | ||
| function isKeyboardEvent(event: React.SyntheticEvent): event is React.KeyboardEvent { | ||
| return 'key' in event && !!event.key; |
Contributor
Author
There was a problem hiding this comment.
This change requires to add run-time logic to remove any, If additional run-time is not required to remove any here, i can revert this change
Member
There was a problem hiding this comment.
The change seems fine to me. 👍🏼
|
This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days. |
github-actions
bot
added
the
stale
michelengelen
removed
the
stale
michelengelen
approved these changes
Jul 30, 2025
| function isKeyboardEvent(event: any): event is React.KeyboardEvent { | ||
| return !!event.key; | ||
| function isKeyboardEvent(event: React.SyntheticEvent): event is React.KeyboardEvent { | ||
| return 'key' in event && !!event.key; |
Member
There was a problem hiding this comment.
The change seems fine to me. 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refines type safety and improves code clarity in the
GridEditSingleSelectCellcomponent within thepackages/x-data-gridpackage. The changes focus on enhancing type definitions and simplifying event handling.