[code-infra] Update some date-pickers tests for vitest #17083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding a type label to the PR! 👍 |
|
Deploy preview: https://deploy-preview-17083--material-ui-x.netlify.app/ |
JCQuintas
changed the title
Janpot
reviewed
Mar 24, 2025
| it('should not use the mobile picker by default', () => { | ||
| // Test with accessible DOM structure | ||
| window.matchMedia = stubMatchMedia(true); |
There was a problem hiding this comment.
edit: nvm, we're still in mocha land, to keep in mind for when we switch to vitest
Suggestion: Create a stubMatchMedia helper that cleans up after itself automatically
import { onTestFinished } from 'vitest'
function stubMatchMedia(matches) {
const original = window.matchMedia
window.matchMedia = ...
onTestFinished(() => {
window.matchMedia = original
})
}The hook is called in reverse order, so it should be safe to call stubMatchMedia multiple times.
Janpot
approved these changes
Mar 24, 2025
LukasTy
reviewed
Mar 24, 2025
| if (!inClock && clockConfig) { | ||
| let timer: sinon.SinonFakeTimers | null = null; | ||
| beforeEach(() => { | ||
| timer = sinon.useFakeTimers({ now: clockConfig, toFake: ['Date'] }); |
There was a problem hiding this comment.
Have you tried using the additional option added in mui/material-ui#43729? 🤔
oliviertassinari
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are improvements made during the
vitestPRI'm moving the changes out so that PR is leaner. The changes mostly revolve around removing
clock='fake'usage.Hopefully these are reasonable enough changes to be merged without issues.