[DataGrid] Add scroll shadows and fix scrollbar overlap #16476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenanYusuf
added
scope: data grid
KenanYusuf
changed the title
|
Deploy preview: https://deploy-preview-16476--material-ui-x.netlify.app/ Updated pages: Bundle size report
|
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
KenanYusuf
commented
May 21, 2025
| bottom: 0, | ||
| }); | ||
|
|
||
| export const ScrollbarCorner = styled(Scrollbar)({ |
There was a problem hiding this comment.
This corner piece covers up the dead zone between the two scrollbars.
| Without | With |
|---|---|
 |
 |
KenanYusuf
changed the title
KenanYusuf
commented
May 22, 2025
packages/x-data-grid/src/components/containers/GridRootStyles.ts
Outdated
Show resolved
Hide resolved
KenanYusuf
force-pushed
the
vertical-scrollbar-include-pinned-rows
branch
from
89a113a to
9707912
Compare
romgrk
reviewed
Jul 29, 2025
Comment on lines
278
to
281
| dimensions.minimumSize.height - dimensions.viewportOuterSize.height, | ||
| dimensions.contentSize.height - dimensions.viewportInnerSize.height, | ||
| ); | ||
| const maxScrollLeft = Math.ceil( | ||
| dimensions.minimumSize.width - dimensions.viewportInnerSize.width, | ||
| dimensions.contentSize.width - dimensions.viewportInnerSize.width, |
There was a problem hiding this comment.
Iiuc, this is a bugfix for the virtualization code?
There was a problem hiding this comment.
Yes, if I'm remembering correctly it fixes a miscalculation.
|
This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
PR: out-of-date
cherniavskii
added
type: enhancement
this fixes the shadow not being shown, when the first pinned column is added by the user when there's a horizontal scroll
|
OK, this PR is ready for review again. |
arminmeh
approved these changes
Sep 22, 2025
romgrk
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-16476--material-ui-x.netlify.app/x/react-data-grid/column-pinning/#pinned-columns-appearance
Conditional scroll shadows
Adds conditional scroll shadows when there are pinned columns and rows. Closes #10001
Screen.Recording.2025-06-25.at.11.05.46.mov
Vertical scrollbar changes
Update vertical scrollbar positioning to cover pinned rows (previous discussion #16379). TLDR; this is a usability improvement, as it currently doesn't look as though you can scroll vertically over pinned rows.
Also fixes #13286
Changelog