[data grid] Pagination issue on row population

[sydneyjodon-wk]

Steps to reproduce

Steps:

1. Open this link to live example: https://stackblitz.com/edit/1yfh2vxy?file=src%2FDemo.tsx
2. Click the populate rows button
3. See that the rows that are displayed go beyond the page size:

Current behavior

Hello 👋 I'm seeing an issue where if a DataGridPro is initially rendered with no rows and I conditionally turn off pagination for no rows, then when I populate the rows, for some reason the pagination turns on, but doesn't function properly. See in the gif how all 11 rows are still displayed even though the pagination says only 5 should be displayed.

Expected behavior

I would expect to be able to change the pagination prop to true and the pagination to both turn on and function properly to only show the amount of rows the page size specifies.

Context

This is happening because our rows are delayed loading in so at first there's no rows and pagination is off, but then we want to turn pagination on when there are rows.

Any help would be appreciated! Thank you!

Your environment

See code sandbox on latest dependencies: https://stackblitz.com/edit/1yfh2vxy?file=src%2FDemo.tsx

Search keywords: pagination, row, no rows, row count

Order ID: 82849

[MBilalShafi]

Thank you @sydneyjodon-wk for reporting the issue, appears to be a side effect of #15666.
I was able to drill it down to only the "pagination" prop update: https://stackblitz.com/edit/1yfh2vxy-dpfnsbwc?file=src%2FDemo.tsx

The pagination state wasn't propagating because of a || instead of &&.

mui-x/packages/x-data-grid/src/hooks/features/pagination/useGridPaginationModel.ts

Line 338 in 80f2a2f

state.pagination.paginationMode === props.paginationMode ||

PR with the fix is up: #19290

[sydneyjodon-wk]

Awesome! Thank you, @MBilalShafi !!

[github-actions]

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@sydneyjodon-wk How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.