[Select] Improve MenuProps.slotProps implementation
#46612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
scope: select
ZeeshanTamboli
changed the title
MenuProps slotPropsMenuProps.slotProps implementation
Netlify deploy previewhttps://deploy-preview-46612--material-ui.netlify.app/ Bundle size report
|
1 task
sai6855
reviewed
Jul 28, 2025
| }; | ||
|
|
||
| const paperProps = { | ||
| ...MenuProps.PaperProps, |
There was a problem hiding this comment.
We do have mergeSlotProps utility, can you check if it's possible to use that here
There was a problem hiding this comment.
I think it's the same reason as https://github.com/mui/material-ui/pull/44913/files#r1957728696, i.e to use the ownerState of Select not the Menu.
sai6855
approved these changes
Jul 28, 2025
|
@sai6855 I think you lost the approving privilege after core team removal from GitHub. I would need an approval from @siriwatknp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #45789 (comment)