Skip to content

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Jul 12, 2025

@sai6855 sai6855 marked this pull request as draft July 12, 2025 06:10
@mui-bot
Copy link

mui-bot commented Jul 12, 2025

Netlify deploy preview

https://deploy-preview-46508--material-ui.netlify.app/

Bundle size report

Bundle Parsed Size Gzip Size
@mui/material 🔺+73B(+0.01%) 🔺+40B(+0.03%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against cd806bd

@@ -424,6 +424,191 @@ describe('<SpeedDial />', () => {
});
});

describe('dial focus with slotProps.fab', () => {
Copy link
Contributor Author

@sai6855 sai6855 Jul 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied this entire describe block and just replaced FabProps with slotProps.fab here, newly added tests serves as proof that whatever tests were passing with FabProps are now passing with slotProps.fab

@sai6855 sai6855 marked this pull request as ready for review July 13, 2025 17:09
@sai6855 sai6855 requested a review from DiegoAndai July 13, 2025 17:10
@zannager zannager added the scope: speed dial Changes related to the speed dial. label Jul 14, 2025
@sai6855 sai6855 added type: bug It doesn't behave as expected. package: material-ui labels Jul 15, 2025
@sai6855 sai6855 requested a review from siriwatknp July 16, 2025 11:04
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @sai6855

@sai6855 sai6855 merged commit 365ee00 into mui:master Jul 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: speed dial Changes related to the speed dial. type: bug It doesn't behave as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][SpeedDial] cannot navigate with arrow keys with slotProps.fab defined
4 participants