[docs-infra] Fix codeblock issues #46323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-46323--material-ui.netlify.app/ Bundle size report
|
atharva3333
changed the title
Janpot
reviewed
Jun 18, 2025
| @@ -235,7 +235,7 @@ export default function MaterialStyling() { | |||
| overflow: 'auto', | |||
| }} | |||
| > | |||
| <Box sx={{ position: 'relative' }}> | |||
| <Box sx={{ position: 'relative', minWidth: 510 }}> | |||
There was a problem hiding this comment.
I wouldn't expect to see a hard-coded width. Isn't there a way to make the highlight follow the width of the code content? Perhaps it's in the wrong container?
There was a problem hiding this comment.
Isn't there a way to make the highlight follow the width of the code content?
We can do that with display: 'inline-block'. It lets it size based on its content width. Also, added minWidth: '100%', to ensure it doesn't become smaller that it's container.
ZeeshanTamboli
changed the title
ZeeshanTamboli
added
type: bug
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
I fixed the second and third point of #43863. Also, refactored FlashCode component to not pass unused variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43863
Resize the window to see the issue and the fix.
Before: https://mui.com/material-ui/
After: https://deploy-preview-46323--material-ui.netlify.app/material-ui/