Skip to content

[Select] Pass MenuProps.slotProps.list alongside MenuListProps #46274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2025
Merged

[Select] Pass MenuProps.slotProps.list alongside MenuListProps #46274

merged 3 commits into from
Jun 10, 2025

Conversation

scousino
Copy link
Contributor

@scousino scousino commented Jun 4, 2025

Fixes #46273

@scousino
[SelectInput] Pass MenuProps.slotProps.list to the internal Menu comp…
697fef0 
…onent using a helper variable listProps that also merges in the now deprecated MenuProps.MenuListProps
@mui-bot
Copy link

mui-bot commented Jun 4, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-46274--material-ui.netlify.app/

Bundle size report

@mui/material parsed: 🔺+32B(+0.01%) gzip: 🔺+2B(0.00%)
@mui/lab parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/system parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/utils parsed: 0B(0.00%) gzip: 0B(0.00%)

Show details for 100 more bundles (86 more not shown)

@mui/material/Select parsed: 🔺+32B(+0.02%) gzip: 🔺+6B(+0.01%)
@mui/material/TablePagination parsed: 🔺+32B(+0.02%) gzip: 🔺+6B(+0.01%)
@mui/material/TextField parsed: 🔺+32B(+0.02%) gzip: 🔺+10B(+0.02%)
@mui/lab/AdapterDateFns parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/AdapterDayjs parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/AdapterLuxon parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/AdapterMoment parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/CalendarPicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/CalendarPickerSkeleton parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/ClockPicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/DatePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/DateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/DateRangePickerDay parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/DateTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/DesktopDatePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/DesktopDateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/DesktopDateTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/DesktopTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/LoadingButton parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/LocalizationProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/Masonry parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/MobileDatePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/MobileDateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/MobileDateTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/MobileTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/MonthPicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/PickersDay parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/StaticDatePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/StaticDateRangePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/StaticDateTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/StaticTimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TabContext parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TabList parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TabPanel parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/Timeline parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TimelineConnector parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TimelineContent parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TimelineDot parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TimelineItem parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TimelineOppositeContent parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TimelineSeparator parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TimePicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TreeItem parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/TreeView parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/useAutocomplete parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/lab/YearPicker parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Accordion parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/AccordionActions parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/AccordionDetails parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/AccordionSummary parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Alert parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/AlertTitle parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/AppBar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Autocomplete parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Avatar parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/AvatarGroup parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Backdrop parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Badge parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/BottomNavigation parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/BottomNavigationAction parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Box parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Breadcrumbs parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Button parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/ButtonBase parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/ButtonGroup parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Card parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/CardActionArea parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/CardActions parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/CardContent parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/CardHeader parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/CardMedia parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Checkbox parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Chip parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/CircularProgress parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/ClickAwayListener parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Collapse parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Container parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/CssBaseline parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/DefaultPropsProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Dialog parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/DialogActions parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/DialogContent parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/DialogContentText parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/DialogTitle parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Divider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Drawer parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Fab parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Fade parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/FilledInput parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/FormControl parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/FormControlLabel parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/FormGroup parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/FormHelperText parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/FormLabel parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/GlobalStyles parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Grid parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/GridLegacy parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Grow parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/Icon parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/material/IconButton parsed: 0B(0.00%) gzip: 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against b183070

@zannager zannager added the scope: select Changes related to the select. label Jun 5, 2025
@zannager zannager requested a review from mj12albert June 5, 2025 06:54
@ZeeshanTamboli ZeeshanTamboli added the type: bug It doesn't behave as expected. label Jun 10, 2025
ZeeshanTamboli
ZeeshanTamboli approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scousino I added a test case. Looks good now! Thanks for the PR.

@ZeeshanTamboli ZeeshanTamboli merged commit da1aedf into mui:master Jun 10, 2025
20 checks passed
@connorshea
Copy link
Contributor

Is it possible to backport this to v6? Or update the v6 deprecation docs to no longer mention the change about MenuListProps, since there's no way to actually resolve the deprecation right now in v6 without this change.

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Aug 22, 2025 •
edited
Loading

@connorshea You're right—but since v7 is more stable, we may not release v6 anymore. But the v6 docs is incorrect in stating that MenuListProps is deprecated without having this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@mj12albert mj12albert Awaiting requested review from mj12albert

Assignees
No one assigned
Labels
scope: select Changes related to the select. type: bug It doesn't behave as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] MenuProps.slotProps.list is not being passed through
5 participants
@scousino @mui-bot @connorshea @ZeeshanTamboli @zannager