-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
[docs][nextjs] Document CSP for Next.js Pages Router #45798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gabriel Rohden <[email protected]>
Signed-off-by: Gabriel Rohden <[email protected]>
docs/data/material/guides/content-security-policy/content-security-policy.md
Outdated
Show resolved
Hide resolved
@Grohden is this ready for review? |
Netlify deploy previewBundle size report |
@aarongarciah oh, sorry, yes it is! |
Co-authored-by: Aarón García Hervás <[email protected]> Signed-off-by: Gabriel Rohden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small copy edits here otherwise I think it's good to go 👍
docs/data/material/guides/content-security-policy/content-security-policy.md
Outdated
Show resolved
Hide resolved
docs/data/material/guides/content-security-policy/content-security-policy.md
Outdated
Show resolved
Hide resolved
docs/data/material/guides/content-security-policy/content-security-policy.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: Gabriel Rohden <[email protected]>
@mapache-salvaje thx for the review! I've applied your suggestions 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Grohden !!
should this also mention how the |
@Janpot you guys decide 🫡 the Links to the vercel docs about how to do it, I felt it would be too big for this doc so I didn't mention it, but up to you all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links to the vercel docs about how to do it
Right, totally glanced over that. Seems good to me
+1 for leaving those details to the Next.js docs so we won't have as much content to keep in sync on our side 😁 |
thank you! |
This is a follow-up for #45794
In this PR I'm documenting how to setup CSP in emotion cache for nextjs page router