Skip to content

[code-infra] Clean up bundle size checker #45622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 14, 2025
Merged

[code-infra] Clean up bundle size checker #45622

merged 7 commits into from
Apr 14, 2025

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 19, 2025 •
edited
Loading

Closes #43441

  • Removing base & joy bundle size checking
  • Uses the full package name and path as the id, no more aliasing
  • Make sure to handle duplicate ids (currently base ui is overwriting core, which gives false results for core)
  • Remove LICENSE.txt files from the output, they're unnecessary
  • Just take a list of packages with their path as input

This PR will establish a new baseline for bundle sizes

@Janpot Janpot added the scope: code-infra Changes related to the core-infra product. label Mar 19, 2025
@mui-bot
Copy link

mui-bot commented Mar 19, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-45622--material-ui.netlify.app/

@material-ui/core: parsed: -100.00% 😍, gzip: -100.00% 😍
@mui/material: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: -100.00% 😍, gzip: -100.00% 😍
TablePagination: parsed: -100.00% 😍, gzip: -100.00% 😍
@mui/material/TablePagination: parsed: +Infinity% , gzip: +Infinity%
@mui/joy/Autocomplete: parsed: -100.00% 😍, gzip: -100.00% 😍
Autocomplete: parsed: -100.00% 😍, gzip: -100.00% 😍
@mui/material/Autocomplete: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: -100.00% 😍, gzip: -100.00% 😍
@mui/lab: parsed: +Infinity% , gzip: +Infinity%
TextField: parsed: -100.00% 😍, gzip: -100.00% 😍
@mui/material/TextField: parsed: +Infinity% , gzip: +Infinity%
Select: parsed: -100.00% 😍, gzip: -100.00% 😍
@mui/material/Select: parsed: +Infinity% , gzip: +Infinity%
SpeedDialAction: parsed: -100.00% 😍, gzip: -100.00% 😍
@mui/material/SpeedDialAction: parsed: +Infinity% , gzip: +Infinity%
@mui/joy/Select: parsed: -100.00% 😍, gzip: -100.00% 😍
@mui/joy/Menu: parsed: -100.00% 😍, gzip: -100.00% 😍
Tooltip: parsed: -100.00% 😍, gzip: -100.00% 😍
@mui/material/Tooltip: parsed: +Infinity% , gzip: +Infinity%
and 445 more changes

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against ab4f2b8

@Janpot Janpot marked this pull request as ready for review March 25, 2025 16:44
@Janpot Janpot requested a review from a team March 25, 2025 16:44
@Janpot Janpot mentioned this pull request Apr 10, 2025
Closed
1 task
@Janpot Janpot changed the title Clean up bundle size names [code-infra] Clean up bundle size checker Apr 10, 2025
mnajdova
mnajdova reviewed Apr 11, 2025
View reviewed changes
scripts/sizeSnapshot/create.js Outdated
@@ -23,6 +23,14 @@ async function getWebpackSizes(webpackEnvironment) {

const entries = await getWebpackEntries();

const seen = new Set();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this code now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just deduplicate now, no need to error

@Janpot Janpot requested a review from mnajdova April 11, 2025 09:24
@Janpot Janpot mentioned this pull request Apr 11, 2025
Merged
mnajdova
mnajdova approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Janpot
Copy link
Member Author

Janpot commented Apr 14, 2025 •
edited
Loading

In the updated bundle size app: https://deploy-preview-304--mui-dashboard.netlify.app/size-comparison?circleCIBuildNumber=817157&baseRef=master&baseCommit=daf94785cb9a562cfc3b00a6fbf9a993f5780827&prNumber=45622

@Janpot Janpot merged commit b8ef49e into mui:master Apr 14, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
scope: code-infra Changes related to the core-infra product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[code-infra] Clean up bundle size names
3 participants
@Janpot @mui-bot @mnajdova