Skip to content

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Feb 7, 2025

Cherry-pick #44540
Cherry-pick #45351

Cherry-picking this as it fixes a regression, which is covered in LTS.

@mui-bot
Copy link

mui-bot commented Feb 7, 2025

Netlify deploy preview

https://deploy-preview-45238--material-ui.netlify.app/

@material-ui/core: parsed: +0.06% , gzip: +0.03%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against bbc347f

@mj12albert mj12albert enabled auto-merge (squash) February 7, 2025 14:29
@DiegoAndai DiegoAndai disabled auto-merge February 7, 2025 14:47
@mj12albert
Copy link
Member

@DiegoAndai any idea what happened with argos? 🤔
https://app.argos-ci.com/mui/material-ui/builds/35626/136163524

@DiegoAndai
Copy link
Member Author

@mj12albert I'll look into it, looks like a font-aliasing thing that we might've fixed in the up-to-date branches but not on this one

@DiegoAndai
Copy link
Member Author

@mj12albert I updated v5.x branch's Argos. Let's wait for #45351 before merging this one.

@DiegoAndai DiegoAndai marked this pull request as ready for review March 6, 2025 12:59
@DiegoAndai DiegoAndai requested a review from mj12albert March 6, 2025 12:59
@mj12albert
Copy link
Member

The test failed in Firefox 123: https://app.circleci.com/pipelines/github/mui/material-ui/149359/workflows/cf08c9ee-9c46-4430-9950-8046bc010541/jobs/802934

In v6.x the tested FF version is 131, though 123 is still supported according to browserslistrc

@DiegoAndai
Copy link
Member Author

@mj12albert I simply increased it from 3 to 4 😅 do you agree with the approach?

@mj12albert
Copy link
Member

I simply increased it from 3 to 4 😅 do you agree with the approach?

👍 I tested increasing the timeout and it seems 4 is stable here 😅 https://app.circleci.com/pipelines/github/mui/material-ui/149623/workflows/a595110d-b5ee-46de-bb4f-87e95fc2e717/jobs/804382/parallel-runs/0/steps/0-111

@DiegoAndai DiegoAndai merged commit c439205 into mui:v5.x Mar 10, 2025
18 checks passed
@DiegoAndai DiegoAndai deleted the cherry-pick-44540 branch March 10, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants