[code-infra] Reconfigure react-remove-properties babel plugin

[Janpot]

• data-mui-test was removed in [test] Remove data-mui-test from tests #23498. In the main babel config this means babel-plugin-react-remove-properties was a no-op. We can't really rely on it because the icons have a data-testid as documented public API.
• data-testid pops are still in the docs. They're not removed from the icons as we're excluding babel on them. Here we can keep babel-plugin-react-remove-properties and reconfigure it to operate on ^data-test.
• Took the opportunity to remove the babel-plugin-macros plugin which we don't use anymore. I didn't realize there was another babel config the docs folder. Looks like this was working because it's pulled in as a peer dependency by another package.
• Removed a data-testid from markdown generated HTML.

Noticed this in #45208
Seeing about 4k occurrences of data-testid in the docs due to it being baked in the icons. We're not transpiling the icons package for performance reasons, and I imagine many with us. For some obscure reason we made this a public API, so we can't just remove them on a minor. Adding as an idea here.

We weren't seeing the warning in Next.js because of vercel/next.js#75682

[mui-bot]

Netlify deploy preview

https://deploy-preview-45218--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f259e95

[oliviertassinari]

History:

• [Dialog] Finish Dialog API functionality + api docs, add alert dialog demo. #4808
• "For some obscure reason" [icons] Expose a data-testid attribute on all svg icons #22634 so that developers can test their icon logic, RTL, etc.

Looking at the rest of the codebase, I only see the pickers components that depend on react-remove-properties to work. Unclear if those should be public API or not.

[Janpot]

so that developers can test their icon logic, RTL, etc.

Couldn't they just provide the data-testid themselves as a prop? Now we're adding this to every icon in the dom, in production in our docs and for every end-user application. It feels like we're also imposing data-testids that the user didn't explicitly set. It may clash with their expectations.

[siriwatknp]

👍 Thanks for the cleanup