Skip to content

Conversation

mapache-salvaje
Copy link
Contributor

@mapache-salvaje mapache-salvaje commented Jan 29, 2025

mui/mui-x#16302 breaks several links in the Material UI docs and MUI blog, so this PR cleans those up.

@mapache-salvaje mapache-salvaje added docs Improvements or additions to the documentation. blog Related to blog content or publication. MUI X labels Jan 29, 2025
@mui-bot
Copy link

mui-bot commented Jan 29, 2025

@mapache-salvaje mapache-salvaje marked this pull request as ready for review February 7, 2025 17:11
@mapache-salvaje
Copy link
Contributor Author

From that PR in the X repo:

Broken links found by `docs:link-check` that exist:

- https://mui.com/x/react-charts/getting-started/
- https://mui.com/x/react-data-grid/#premium-plan
- https://mui.com/x/react-data-grid/getting-started/
- https://mui.com/x/react-data-grid/getting-started/#feature-comparison
- https://mui.com/x/react-date-pickers/fields/#accessible-dom-structure
- https://mui.com/x/react-date-pickers/getting-started/
- https://mui.com/x/react-date-pickers/quickstart/#date-and-time-types
- https://mui.com/x/react-tree-view/#rich-tree-view
- https://mui.com/x/react-tree-view/#simple-tree-view
- https://mui.com/x/react-tree-view/getting-started/

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mapache-salvaje!

Curious: Was this caught by our CI or any other monitoring system?

@mapache-salvaje
Copy link
Contributor Author

@DiegoAndai this was the result from running pnpm docs:link-check on the X side after I changed the names and locations of some of the docs over there in the PR linked above. These links aren't broken yet, but that PR should land in the next X release at the end of this week, and then they'll all be broken over here and picked up by the CI check. Does that make sense?

@DiegoAndai
Copy link
Member

Thanks for the explanation 👍🏼

@mapache-salvaje mapache-salvaje merged commit 1ea508c into mui:master Feb 18, 2025
22 checks passed
@mapache-salvaje mapache-salvaje added needs cherry-pick The PR should be cherry-picked to master after merge. v6.x labels Mar 4, 2025
mapache-salvaje added a commit to mapache-salvaje/material-ui that referenced this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog Related to blog content or publication. docs Improvements or additions to the documentation. MUI X needs cherry-pick The PR should be cherry-picked to master after merge. v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants