[docs][material-ui] Add missing required dependencies in dashboard template README #44476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Ban <[email protected]>
Signed-off-by: Luca Ban <[email protected]>
zanivan
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Thanks for the keen eye, @mesqueeb !
-
@noraleonte do you remember any other dependency we need to include in the dashboard template?
-
@samuelsycamore based on #44461 maybe it's also worth reviewing the templates' README files 😅
zanivan
changed the title
Netlify deploy previewBundle size report |
zanivan
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems the list was missing these dependencies. I tried a fresh install and vite complained that they needed to be installed. after doing so, it successfully launched.