[lab][Tabs] Fix type of TabPanel component #44207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-44207--material-ui.netlify.app/ Bundle size report |
aarongarciah
changed the title
|
Hey @blackcow1987, thanks for opening the PR. May I ask why do you need this change? If we change the type of the |
aarongarciah
requested review from
aarongarciah
and removed request for
siriwatknp
|
@aarongarciah The reason why we need to change the type of value is because a warning occurs due to a type mismatch with the |
aarongarciah
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks for the contribution! I see that #40829 introduced this change for TabContext; we should've introduced it in TabPanel back then.
ZeeshanTamboli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the value type of
TabPanelcomponent fromstringtostring | number