[material-ui][Divider] Fix CSS specificity order #44204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
changed the title
Netlify deploy previewhttps://deploy-preview-44204--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
|
See this repo for the repro; it's based on MUI's pigment vite example (but it isn't related to Pigment).
Then, here's a video on how to reproduce how this PR fixes it (removing style from the parent HTML element and applying to the span with text) Screen.Recording.2024-10-27.at.6.29.49.AM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently CSS specificity order issue.
If a user has a global CSS override, such as:
Then
Dividercomponent will become broken, there'll be extra line breaksthat's because the
whiteSpace: 'nowrap'is currently set on the parent HTML element, instead of the actual wrapper.