Skip to content

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 9, 2024

This was added in #24614, I never understood the use case. In the latest releases https://github.com/mui/material-ui/issues?q=label%3Arelease+is%3Aclosed some maintainers remove them, some keep them, e.g. #44038 has it but the one before doesn't: #43957. So it feels like we should drop this, it adds so much noise during the release PR review.

@oliviertassinari oliviertassinari added the internal Behind-the-scenes enhancement. Formerly called “core”. label Oct 9, 2024
@mui-bot
Copy link

mui-bot commented Oct 9, 2024

Netlify deploy preview

https://deploy-preview-44052--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a7f6f96

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, the items are anyway sorted, so I don't think we are loosing much.

@mnajdova mnajdova merged commit 488c8fa into mui:master Oct 10, 2024
20 checks passed
@oliviertassinari oliviertassinari deleted the clean-up-changelog branch October 11, 2024 11:27
@oliviertassinari
Copy link
Member Author

Alright, sweet.

Oops, I didn't correctly rebase this PR. I missed some changes with this PR, fixed in 82a8253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Behind-the-scenes enhancement. Formerly called “core”. scope: code-infra Changes related to the core-infra product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants