Skip to content

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Oct 6, 2024

Noticed warnings when running the docs

Warning: Failed prop type: The prop `size` of `Grid2` can only be used together with the `item` prop.

@Janpot Janpot added type: bug It doesn't behave as expected. component: Grid The React component. labels Oct 6, 2024
@mui-bot
Copy link

mui-bot commented Oct 6, 2024

Netlify deploy preview

https://deploy-preview-44027--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 93cbd77

@Janpot Janpot marked this pull request as ready for review October 6, 2024 15:06
@Janpot Janpot requested a review from siriwatknp October 6, 2024 16:13
@mnajdova mnajdova requested review from DiegoAndai and removed request for siriwatknp October 7, 2024 07:16
@mnajdova
Copy link
Member

mnajdova commented Oct 7, 2024

Isn't this a wrong usage then? cc @DiegoAndai

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, item is no longer a prop in the new grid, nevermind, looks good 👌

@mnajdova mnajdova merged commit be78d87 into mui:master Oct 7, 2024
8 checks passed
@Janpot Janpot deleted the remive-grid2-required-item-prop branch October 7, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Grid The React component. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants