[code-infra] Fix flaky dashboard screenshot - take 2 #43937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
test
scope: code-infra
Netlify deploy previewhttps://deploy-preview-43937--material-ui.netlify.app/ Bundle size report |
Signed-off-by: Jan Potoms <[email protected]>
mnajdova
approved these changes
Oct 1, 2024
Member
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
The changes make sense. Let's try this and see how it will behave
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still seeing flakyness after #43890. I could reproduce locally after switching the scrollbar visibility setting on my laptop. Just disabling overflow on the body seems to fix it reliably for any of the settings. There is now also a noticable difference in all screenshots of elements that overflow. Looks like this change is an improvement for those screenshots as well.
Doing the same for pigment regression tests.
Make sure to check out the changed screenshots