Skip to content

[examples] Fix v5 clone example instructions #43755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

oliviertassinari
Copy link
Member

I tried to run those commands to test something on a new project but it didn't work.

@oliviertassinari oliviertassinari added v5.x examples Relating to /examples. type: bug It doesn't behave as expected. labels Sep 14, 2024
@mui-bot
Copy link

mui-bot commented Sep 14, 2024

Netlify deploy preview

https://deploy-preview-43755--material-ui.netlify.app/

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 50785b6

@oliviertassinari
Copy link
Member Author

cc @alelthomas notification test 😄

@oliviertassinari oliviertassinari changed the title [examples] Fix clone example instructions [examples] Fix v5 clone example instructions Oct 2, 2024
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I am adding the step to the major release guide (nice, you already did it :)).

@oliviertassinari
Copy link
Member Author

@mnajdova Yeah, I reworked the major release guide to merge Core and X. There are some differences, but the best practices seems to be the same between Base UI, Material UI, Pigment CSS, MUI X. I saw stuff missing in each version. https://mui-org.notion.site/React-Major-version-release-process-0178410ef26941e6a4f333f80ded127a

@oliviertassinari oliviertassinari merged commit f6181da into mui:v5.x Oct 3, 2024
20 checks passed
@oliviertassinari oliviertassinari deleted the fix-examples-v5 branch October 3, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Relating to /examples. type: bug It doesn't behave as expected. v5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants