[utils] Fix "useId" & "useSyncExternalStore" imports to not be statically analyzable #43360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43360--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
yash49
changed the title
yash49
changed the title
oliviertassinari
changed the title
|
hi @atomiks, can you please review this tiny pr? |
atomiks
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
I also switched from toString() to the {...React} technique in https://github.com/floating-ui/floating-ui and it has worked without issue.
|
Thank you @atomiks for reviewing the PR. @oliviertassinari / @zannager can we merge this PR ? |
Janpot
approved these changes
Aug 28, 2024
oliviertassinari
force-pushed
the
bug/make-imports-statically-unanalysable
branch
from
1a38207 to
f28f154
Compare
oliviertassinari
changed the title
|
I did some clean-up. I think it's ready to be merged? Looking at the useId inspired me to open mui/base-ui#616. |
oliviertassinari
changed the title
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #41190