[material-ui][Autocomplete] Fix default value for multiple mode getting redefined with React 19 #43189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
package: material-ui
scope: autocomplete
DiegoAndai
changed the title
Netlify deploy previewhttps://deploy-preview-43189--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Member
Author
|
@michaldudak does this change make sense to you? Without these, the "controlled to uncontrolled" error throws here: Just double checking if there's no better solution here. |
michaldudak
approved these changes
Aug 6, 2024
Member
michaldudak
left a comment
michaldudak
left a comment
There was a problem hiding this comment.
It makes sense for sure 👍. I'm just not aware why this started to be a problem only now with React 19.
Member
Author
I was wondering the same 😅 Thanks fro reviewing! |
37 tasks
DiegoAndai
added a commit
to DiegoAndai/material-ui
that referenced
this pull request
Nov 26, 2024
…ng redefined with React 19 (mui#43189)
DiegoAndai
added a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #42824
I couldn't find a reason in the React 19 upgrade guide for why this change was necessary. What I understand is that because the array is being defined on every render, it's not stable. Users would have to change this as well when upgrading to React 19.