Skip to content

Conversation

@zanivan
Copy link
Collaborator

@zanivan zanivan commented Aug 2, 2024

Adding icons to the products on the core page of the website to ensure consistency across the website navigation. We already have them on the app bar menu and in the docs, so this will make the experience uniform throughout.

👉 https://deploy-preview-43151--material-ui.netlify.app/core/

@zanivan zanivan added design This is about UI or UX design, please involve a designer. website Pages that are not documentation-related, marketing-focused. labels Aug 2, 2024
@zanivan zanivan self-assigned this Aug 2, 2024
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wonder if we could experience with box-less icons, as we have in the menu bar.

@zanivan
Copy link
Collaborator Author

zanivan commented Aug 5, 2024

@aarongarciah that's because we're using the InfoCard. So, I see 2 options:

  1. Use a different custom component for this page, specifically
  2. Tweak all instances of InfoCard

I don't know if this is worth, though, since we're aiming to move away from the concept of “core” components. But I'd vote for 1 here, if you think we should try it anyway, since InfoCard should be for information, not clicks.

@aarongarciah
Copy link
Member

I think this is already an improvement so I'd go with it and improve it in another PR if you think it's worth it.

@zanivan zanivan merged commit f9de2dd into next Aug 5, 2024
@zanivan zanivan deleted the add-icon-mui-core branch August 5, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design This is about UI or UX design, please involve a designer. website Pages that are not documentation-related, marketing-focused.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants