[docs] Refine and polish out Templates page #43131
Conversation
zanivan
added
docs
zanivan
changed the title
Netlify deploy preview
Bundle size report |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
@samuelsycamore would you mind doing a pass-through on this page content and also the templates to detect any typos or improvements? |
|
@siriwatknp I think the Argos test is detecting many screenshots from the marketing page template (old landing page template). Could this be related to the new screenshot script? Otherwise, can I approve the Argos test? |
|
Just a small bump on this one, I need to merge it to start working on the theme unification and consistency @siriwatknp @DiegoAndai @samuelsycamore |
mapache-salvaje
left a comment
mapache-salvaje
left a comment
There was a problem hiding this comment.
text looks good to me!
siriwatknp
left a comment
siriwatknp
left a comment
There was a problem hiding this comment.
We might need to revisit the regression tests for templates next. I encounter unrelated Argos changes in other PRs from templates (especially with charts) multiple times.
This PR addresses some items from #41469 :
12. Rename the “landing page” template given it looks more like a home page
14. Allow to click on the image to open it. Uploading Screen Recording 2024-06-10 at 18.14.18.mov…
The changes made were:
landing-pagetomarketing-page(that's why there are so many files changed)PricingandStickyFootertemplatesCardImage