Skip to content

[material-ui][Divider] Enable borderStyle enhancement in divider with children (@anuujj) #43059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 25, 2024
Merged

[material-ui][Divider] Enable borderStyle enhancement in divider with children (@anuujj) #43059

merged 6 commits into from
Jul 25, 2024

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Jul 24, 2024

Cherry-pick of #42715

@github-actions github-actions bot added cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. scope: divider Changes related to the divier. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. needs cherry-pick The PR should be cherry-picked to master after merge. package: material-ui labels Jul 24, 2024
@mui-bot
Copy link

mui-bot commented Jul 24, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43059--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against e924c9c

DiegoAndai
DiegoAndai requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automatic cherry pick doesn't work as the styled argument is different between master and next. I'll try to update this this week.

@anuujj or @ZeeshanTamboli if you want to take a look before I get to it, feel free to do so.

@DiegoAndai DiegoAndai self-assigned this Jul 24, 2024
@ZeeshanTamboli ZeeshanTamboli removed the needs cherry-pick The PR should be cherry-picked to master after merge. label Jul 25, 2024
DiegoAndai
DiegoAndai approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZeeshanTamboli

@DiegoAndai DiegoAndai merged commit 4e38398 into master Jul 25, 2024
@DiegoAndai DiegoAndai deleted the cherry-pick-42715 branch July 25, 2024 21:17
This was referenced Aug 21, 2024
Open
Open
@leachjustin18 leachjustin18 mentioned this pull request Aug 21, 2024
Merged
@mtrq-capco mtrq-capco mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 21, 2024
Closed
Closed
This was referenced Aug 21, 2024
Open
Open
@prathik2401 prathik2401 mentioned this pull request Aug 21, 2024
Merged
@sufi0900 sufi0900 mentioned this pull request Aug 21, 2024
Open
@DanneelsSophie DanneelsSophie mentioned this pull request Aug 21, 2024
Open
@Maarten-DLVW Maarten-DLVW mentioned this pull request Sep 30, 2024
Open
@l0renz02017 l0renz02017 mentioned this pull request Oct 2, 2024
Open
@ArchismwanChatterjee ArchismwanChatterjee mentioned this pull request Oct 2, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Oct 3, 2024
Open
@firepenguindisopanda firepenguindisopanda mentioned this pull request Oct 3, 2024
Open
@RTHariSankar RTHariSankar mentioned this pull request Oct 3, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request Oct 3, 2024
Open
@DanneelsSophie DanneelsSophie mentioned this pull request Oct 3, 2024
Open
@mattboddy47 mattboddy47 mentioned this pull request Oct 3, 2024
Open
@sergivj sergivj mentioned this pull request Oct 3, 2024
Open
@sufi0900 sufi0900 mentioned this pull request Oct 3, 2024
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Oct 3, 2024
Open
@dexamundsen dexamundsen mentioned this pull request Oct 4, 2024
Closed
@ranjith221132 ranjith221132 mentioned this pull request Oct 5, 2024
Open
@sergivj sergivj mentioned this pull request Oct 26, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request Oct 26, 2024
Open
@tanyo76 tanyo76 mentioned this pull request Oct 27, 2024
Open
@mattboddy47 mattboddy47 mentioned this pull request Oct 28, 2024
Open
@q1blue q1blue mentioned this pull request Oct 29, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Oct 31, 2024
Open
@RTHariSankar RTHariSankar mentioned this pull request Oct 31, 2024
Open
@sufi0900 sufi0900 mentioned this pull request Oct 31, 2024
Open
@PaolaQ-I PaolaQ-I mentioned this pull request Nov 1, 2024
Open
@mflorezmejia mflorezmejia mentioned this pull request Nov 1, 2024
Open
@CharlesGuerrero14 CharlesGuerrero14 mentioned this pull request Nov 2, 2024
Open
@DanneelsSophie DanneelsSophie mentioned this pull request Nov 3, 2024
Open
This was referenced Nov 3, 2024
Open
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Nov 5, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees

@DiegoAndai DiegoAndai

Labels

cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. scope: divider Changes related to the divier. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mui-bot @DiegoAndai @ZeeshanTamboli @anuujj