Skip to content

Conversation

@ijxy
Copy link
Contributor

@ijxy ijxy commented Jun 29, 2024

Closes #42760

@ijxy ijxy changed the title [material-ui] Support CssVarsTheme in responsiveFontSizes types (#42760) [material-ui] Support CssVarsTheme in responsiveFontSizes types Jun 29, 2024
@ZeeshanTamboli ZeeshanTamboli added typescript package: material-ui customization: theme Higher level theming customizability. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. needs cherry-pick The PR should be cherry-picked to master after merge. labels Jun 30, 2024
@mui-bot
Copy link

mui-bot commented Jun 30, 2024

Netlify deploy preview

https://deploy-preview-42786--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against fc982cc

@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui] Support CssVarsTheme in responsiveFontSizes types [material-ui] Support CssVarsTheme in responsiveFontSizes return type Jun 30, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui] Support CssVarsTheme in responsiveFontSizes return type [material-ui] Support CssVarsTheme in responsiveFontSizes return type Jun 30, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jxdp Thanks for the contribution. I have also added type tests.

@ZeeshanTamboli ZeeshanTamboli merged commit d238f98 into mui:next Jun 30, 2024
github-actions bot pushed a commit that referenced this pull request Jun 30, 2024
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customization: theme Higher level theming customizability. needs cherry-pick The PR should be cherry-picked to master after merge. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@mui/material: incorrect responsiveFontSizes return type when using CssVarsTheme as input

3 participants