Skip to content

[material-ui][AppBar] Fix inherit color is inconsistent between ThemeProvider and CssVarsProvider #42713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 11, 2024
Merged

[material-ui][AppBar] Fix inherit color is inconsistent between ThemeProvider and CssVarsProvider #42713

merged 5 commits into from
Jul 11, 2024

Conversation

@ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jun 22, 2024 •
edited
Loading

@ZeeshanTamboli ZeeshanTamboli added type: bug It doesn't behave as expected. scope: app bar Changes related to the app bar. package: material-ui customization: theme Higher level theming customizability. labels Jun 22, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][AppBar] Fix inherit color is inconsistent between ThemeProvider and CSSVarsProvider [material-ui][AppBar] Fix inherit color is inconsistent between ThemeProvider and CssVarsProvider Jun 22, 2024
@mui-bot
Copy link

mui-bot commented Jun 22, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42713--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against f995599

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review June 22, 2024 14:37
@ZeeshanTamboli ZeeshanTamboli added the type: regression A bug, but worse, it used to behave as expected. label Jun 22, 2024
This was referenced Jun 22, 2024
Closed
Merged
DiegoAndai
DiegoAndai approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZeeshanTamboli 💙

@ZeeshanTamboli ZeeshanTamboli merged commit 7c65f7c into mui:master Jul 11, 2024
@ZeeshanTamboli ZeeshanTamboli deleted the issue-42379-AppBar-color-inherit-inconsistent branch July 11, 2024 10:31
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Jul 11, 2024
Merged
@manish02-code manish02-code mentioned this pull request Aug 2, 2024
Open
@tristenwallace tristenwallace mentioned this pull request Aug 2, 2024
Open
This was referenced Aug 2, 2024
Open
Open
This was referenced Aug 2, 2024
Open
Open
This was referenced Aug 2, 2024
Open
Open
@prathik2401 prathik2401 mentioned this pull request Aug 2, 2024
Merged
@DanneelsSophie DanneelsSophie mentioned this pull request Aug 11, 2024
Open
@aqibawan12 aqibawan12 mentioned this pull request Aug 11, 2024
Open
@GitLukeW GitLukeW mentioned this pull request Aug 11, 2024
Open
@sergivj sergivj mentioned this pull request Aug 11, 2024
Open
@Poseidon-G Poseidon-G mentioned this pull request Aug 11, 2024
Open
This was referenced Aug 12, 2024
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 13, 2024
Open
Open
This was referenced Aug 13, 2024
Open
Open
@sufi0900 sufi0900 mentioned this pull request Aug 15, 2024
Open
@RTHariSankar RTHariSankar mentioned this pull request Aug 15, 2024
Open
@sergivj sergivj mentioned this pull request Aug 15, 2024
Open
@mattboddy47 mattboddy47 mentioned this pull request Aug 15, 2024
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Aug 15, 2024
Open
@go-benchmark1 go-benchmark1 mentioned this pull request Aug 16, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Aug 16, 2024
Open
@DanneelsSophie DanneelsSophie mentioned this pull request Aug 16, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Aug 16, 2024
Open
@Stevesanchl Stevesanchl mentioned this pull request Aug 16, 2024
Open
@aqibawan12 aqibawan12 mentioned this pull request Aug 16, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request Aug 18, 2024
Open
@GitLukeW GitLukeW mentioned this pull request Aug 18, 2024
Open
@talhasabri talhasabri mentioned this pull request Aug 20, 2024
Closed
@oliviertassinari oliviertassinari removed the type: bug It doesn't behave as expected. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees

No one assigned

Labels

customization: theme Higher level theming customizability. scope: app bar Changes related to the app bar. type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[material-ui][AppBar] color="inherit" is inconsistent between ThemeProvider and experimental_CssVarsProvider

4 participants

@ZeeshanTamboli @mui-bot @DiegoAndai @oliviertassinari