[core] Apply React 19 type changes that don't require upcoming @types/ packages
#42346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
typescript
internal
Netlify deploy previewhttps://deploy-preview-42346--material-ui.netlify.app/ Bundle size report |
DiegoAndai
force-pushed
the
react-19-types
branch
from
30af6f2 to
8d43e83
Compare
DiegoAndai
force-pushed
the
react-19-types
branch
from
7898446 to
95e3c07
Compare
DiegoAndai
changed the title
@types/ packages
michaldudak
approved these changes
May 24, 2024
Member
michaldudak
left a comment
michaldudak
left a comment
There was a problem hiding this comment.
I didn't check all the files but the changes make sense. I agree that we should progressively improve the ReactElement situation.
This was referenced May 24, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
37 tasks
DiegoAndai
added a commit
to DiegoAndai/material-ui
that referenced
this pull request
Nov 19, 2024
DiegoAndai
added a commit
that referenced
this pull request
Nov 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #42032
First step towards #42032
Summary
This PR includes the type changes we can implement without upgrading to the new
@types/packages (which is a WIP). It's achieved by:npx types-react-codemod@latest preset-19but skipping theuseRef-required-initialcodemod (See missing section below)npx types-react-codemod@latest react-element-default-any-propsto maintainReactElement's previous default.This results in the following changes:
JSXusage in favor ofReact.JSXReactElement<any>to retain the previous defaultMissing
The following are missing, to be implemented after DefinitelyTyped/DefinitelyTyped#69022 is merged:
useRef-required-initialcodemod yet. This is because it will be much easier with the newuseRef(undefined)overload that's coming.npx types-react-codemod@latest react-element-default-any-propsis provided, it is discouraged. We should eventually fix them to work with theunknowndefault.@emotion/[email protected]references deprecated global JSX namespace. They mention they'll work on it once React 19 is released. We could look into contributing to it.