[docs-infra] Share code for section title #42236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
the
scope: docs-infra
Netlify deploy previewhttps://deploy-preview-42236--material-ui.netlify.app/ Bundle size report |
Janpot
approved these changes
May 15, 2024
Member
Janpot
left a comment
Janpot
left a comment
There was a problem hiding this comment.
Not sure about the file position. I hesitated to put this component inside a folder containing small UI components, but did not find a name for it
I'm thinking for the future we can collect them in a single module that contains building blocks for API pages, docs pages and landing pages. e.g. @mui/docs/pages, or @mui/docs/content,... In the meantime this is probably good enough. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export a component to render a section title.
Pages are still responsible for the definition of the translation since they have different approaches. But at least the classes and the DOM structure will be shared.
Not sure about the file position. I hesitated to put this component inside a folder containing small UI components, but did not find a name for it