Skip to content

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 8, 2023

In the support/sales channel, we from time to time have people that don't know that the data grid row can be expanded. https://deploy-preview-35767--material-ui.netlify.app/pricing/?expand-path=all

@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. website Pages that are not documentation-related, marketing-focused. labels Jan 8, 2023
@mui-bot
Copy link

mui-bot commented Jan 8, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-35767--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against c23181e

capped at ten licenses; you do not need to pay for additional licenses for more than
ten developers. You can contact <Link href="mailto:[email protected]">sales</Link> for a
volume discount when licensing over 50 developers under the Premium plan.
volume discount when licensing over 25 developers under the Premium plan.
Copy link
Member Author

@oliviertassinari oliviertassinari Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix to match with the behavior in https://mui.com/store/items/mui-x-premium/.

height: '100%',
'&:hover': {
bgcolor: alpha(theme.palette.grey[50], 0.4),
bgcolor: alpha(theme.palette.primary.main, 0.06),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change a bit the look & feel to improve the expand button affordance.

const [dataGridCollapsed, setDataGridCollapsed] = React.useState(false);

React.useEffect(() => {
if (router.query['expand-path'] === 'all') {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joserodolfofreitas joserodolfofreitas self-requested a review January 10, 2023 12:22
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Olivier Tassinari <[email protected]>
@oliviertassinari oliviertassinari merged commit e85b0f6 into mui:master Jan 15, 2023
@oliviertassinari oliviertassinari deleted the pricing-improve-age branch January 15, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug It doesn't behave as expected. website Pages that are not documentation-related, marketing-focused.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants