Skip to content

Conversation

@danilo-leal
Copy link
Collaborator

@danilo-leal danilo-leal commented Mar 30, 2022

@danilo-leal danilo-leal added the blog Related to blog content or publication. label Mar 30, 2022
@danilo-leal danilo-leal marked this pull request as draft March 30, 2022 02:45
@mui-bot
Copy link

mui-bot commented Mar 30, 2022

No bundle size changes

Generated by 🚫 dangerJS against 2e2213a

@danilo-leal
Copy link
Collaborator Author

danilo-leal commented Mar 30, 2022

@samuelsycamore Tagging you here early so we work on it while it is on draft =) PS: I'd love to get thoughts on the URL. Unsure if the one I came up with is good enough (feeling like it isn't!).

@siriwatknp siriwatknp mentioned this pull request Mar 31, 2022
32 tasks
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

@danilo-leal danilo-leal marked this pull request as ready for review April 4, 2022 14:40
Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! In addition to my suggestions here, I'll leave a separate comment with some ideas to beef up the title and description.

@siriwatknp
Copy link
Member

@samuelsycamore Should we mention the copywriting update on the home page in this blog post as well?

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, looks great otherwise.

Co-authored-by: Andrew Cherniavskii <[email protected]>
Co-authored-by: Marija Najdova <[email protected]>
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have a blog post to announce this change 👍

- Data Grid: [https://mui.com/x/react-data-grid/](https://mui.com/x/react-data-grid/)
- Date and Time Pickers: [https://mui.com/x/react-date-pickers/](https://mui.com/x/react-date-pickers/getting-started/)

> 📖 The MUI X date and time pickers has been moved from the lab (`@mui/lab`). If you are curious about it, check out the [dedicated blog post](/blog/lab-date-pickers-to-mui-x/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> 📖 The MUI X date and time pickers has been moved from the lab (`@mui/lab`). If you are curious about it, check out the [dedicated blog post](/blog/lab-date-pickers-to-mui-x/).
> 📖 The MUI X date and time pickers have been moved from the lab (`@mui/lab`). If you are curious about it, check out the [dedicated blog post](/blog/lab-date-pickers-to-mui-x/).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe to be clearer:

Suggested change
> 📖 The MUI X date and time pickers has been moved from the lab (`@mui/lab`). If you are curious about it, check out the [dedicated blog post](/blog/lab-date-pickers-to-mui-x/).
> 📖 The date and time pickers have been promoted from the lab (`@mui/lab`) to MUI X, saying MIT licensed. If you are curious about it, check out the [dedicated blog post](/blog/lab-date-pickers-to-mui-x/).

Copy link
Collaborator Author

@danilo-leal danilo-leal Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to @samuelsycamore for these grammar revisions (there are others below if you could take a look!). Regardless, the notion of "promoted" is good!


<img src="/static/blog/docs-updates/docs-product-label.png" style="width: 796px; margin-top: 16px; margin-bottom: 16px;" alt="Screenshot of the search results displaying product labels per result" />

As a side benefit of the documentation restructuring, we have seen a huge improvement in the quality of search results related to MUI X. Data Grid users can now see comprehensive results when searching for features. Here is a comparison of before and after when searching for the "pagination" feature:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As a side benefit of the documentation restructuring, we have seen a huge improvement in the quality of search results related to MUI X. Data Grid users can now see comprehensive results when searching for features. Here is a comparison of before and after when searching for the "pagination" feature:
As a side benefit of the documentation restructuring, we have seen a huge improvement in the quality of search results related to MUI X. Data grid users can now see comprehensive results when searching for features. Here is a comparison of before and after when searching for the "pagination" feature:

- _MUI Base_ —unstyled components for implementing your own design system
- _MUI System_ —CSS utilities for quickly laying out design systems
- **MUI X**—a collection of advanced components for complex use cases, including:
- _Data Grid_ —fast, feature-rich, extendable React data table
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- _Data Grid_ —fast, feature-rich, extendable React data table
- _Data grid_ —fast, feature-rich, extendable React data table

- _MUI System_ —CSS utilities for quickly laying out design systems
- **MUI X**—a collection of advanced components for complex use cases, including:
- _Data Grid_ —fast, feature-rich, extendable React data table
- _Date and Time Pickers_ —interface control components for selecting dates and times
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- _Date and Time Pickers_ —interface control components for selecting dates and times
- _Date and Time pickers_ —interface control components for selecting dates and times

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation. label Apr 7, 2022
Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one tiny grammar fix here and then I think it's ready!

Co-authored-by: Sam Sycamore <[email protected]>
@siriwatknp siriwatknp merged commit ffd6895 into mui:master Apr 8, 2022
@danilo-leal danilo-leal deleted the blog-docs-separation branch April 8, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blog Related to blog content or publication. docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants