[pickers] Enable the sx prop on all components
#30749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/lab: parsed: -0.19% 😍, gzip: -0.06% 😍 |
mnajdova
requested changes
Jan 24, 2022
|
Hi @mnajdova, thanks a lot for the quick review, I really appreciate your time and your effort. Your review encouraged me to go ahead in the PR. |
mnajdova
changed the title
mnajdova
approved these changes
Jan 25, 2022
|
@flaviendelangle FYI |
|
Thanks ! |
2 tasks
|
Hi @mnajdova, thanks a lot for accepting the changes. |
mnajdova
changed the title
sx prop on all components
1 task
wladimirguerra
pushed a commit
to wladimirguerra/material-ui
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29385
This fixes the problem of not being able to change the style of internal components despite passing the prop
sx. The problem happens because of using the optionskipSx. In order to fix that we removed the optionskipSxfrom all components and we removed the option from the utilitystyled.Note:
I’m not sure about the changes in the file TYPESCRIPT_CONVENTION.md.