[TouchRipple] Remove MuiTouchRipple from the theme #28631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
the
breaking change
aniruddhabagal
approved these changes
Oct 1, 2021
|
@eps1lon seems like we missed this one before v5 stable. Should this be a part of v6 then? |
Possibly which is why I added the milestone. At least it can't be part of 5.x |
|
I am closing the issue, we can re-open once we actually start to actively work on v6. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing MuiTouchRipple from the theme since it's now considered private.
Also added a TypeScript example in the v4 migration for adding hint text to the theme.
Closes: #28551