[core] Fix various potential issues with multiple windows #22159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +0.09% , gzip: +0.08% |
eps1lon
reviewed
Aug 11, 2020
| @@ -151,7 +151,7 @@ const ButtonBase = React.forwardRef(function ButtonBase(props, ref) { | |||
| 'stop', | |||
| (event) => { | |||
| if (focusVisible) { | |||
| onBlurVisible(event); | |||
| onBlurVisible(); | |||
There was a problem hiding this comment.
This is currently not needed but will be in the future with React 17. onBlurVisible already has a notice so this shouldn't be changed.
eps1lon
requested changes
Aug 11, 2020
eps1lon
changed the title
scottander
force-pushed
the
global-cleanup
branch
from
02becc6 to
82d11e3
Compare
|
Thanks @eps1lon, I have hopefully have addressed your feedback. |
eps1lon
approved these changes
Aug 12, 2020
oliviertassinari
approved these changes
Aug 12, 2020
|
@scottander Great work, thanks! |
oliviertassinari
added
the
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to maintain compatibility with multiple windows, it is optimal to not use the window or document global in most cases.
I have done some cleanup where I believe the usage of these globals was not correct.
I was hoping that since the scope of these changes was fairly minor that i would encapsulate them in one PR.