[test] Update test-utils and remove enzyme #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
changed the title
michaldudak
force-pushed
the
test-utils-update
branch
from
143d2cd to
9a7fd57
Compare
Netlify deploy preview |
michaldudak
force-pushed
the
test-utils-update
branch
2 times, most recently
from
e084eb7 to
3cd803c
Compare
michaldudak
force-pushed
the
test-utils-update
branch
from
3cd803c to
d3be7d7
Compare
michaldudak
force-pushed
the
test-utils-update
branch
from
d3be7d7 to
070b3ed
Compare
colmtuite
approved these changes
Jul 3, 2024
atomiks
approved these changes
Jul 5, 2024
| const render = async (element: React.ReactElement, options?: RenderOptions) => | ||
| act(async () => { | ||
| const result = await originalRender(element, options); | ||
| await flushMicrotasks(); |
Member
There was a problem hiding this comment.
This looks strange. Why does Base UI needs those await when the other repositories don't?
Member
Author
There was a problem hiding this comment.
Most of our components rely on Floating UI, which requires this pattern for testing in some cases. I figured it's better to always wait for pending promises instead of deciding on test-by-test basis (which also makes the test more close to what users perceive).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the latest internal-test-utils (mui/material-ui#42771) with the fixed
flushMicrotasksfunction.Fixed a few tests that were failing after this change.
Ported mui/material-ui#42706 to our repo, removing Enzyme completely.