[toggle-group][toggle] type safety #3173
Open
+118
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhazan
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
michaelhazan
force-pushed
the
toggle-group-type-safety
branch
from
787028e to
84ff83c
Compare
michaelhazan
force-pushed
the
toggle-group-type-safety
branch
from
84ff83c to
b5ae7e4
Compare
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Michael Hazan <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
mj12albert
reviewed
Nov 8, 2025
michaelhazan
force-pushed
the
toggle-group-type-safety
branch
from
f39e177 to
81f77e4
Compare
michaelhazan
force-pushed
the
toggle-group-type-safety
branch
from
81f77e4 to
a3ea128
Compare
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Michael Hazan <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
LukasTy
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3142 .
Note
Originally this was meant to only introduce generic types to the
ToggleGroup, but i realized while working on this thatToggletoo had to be changed to handle a generic value.